GH-39330: [Java][CI] Fix or suppress spurious errorprone warnings #39529

vibhatha · 2024-01-09T08:17:28Z

Rationale for this change

This PR fixes the warnings generated by the errorprone library.

What changes are included in this PR?

Updating the code to remove warnings.

Covered modules

Are these changes tested?

Tested by existing test cases.

Are there any user-facing changes?

No

Closes: [Java][CI] Fix or suppress spurious errorprone warnings #39330

vibhatha · 2024-01-10T03:14:08Z

@github-actions crossbow submit java

github-actions · 2024-01-10T03:16:25Z

Revision: 4d87301

Submitted crossbow builds: ursacomputing/crossbow @ actions-4547e26b60

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-10T05:39:05Z

@github-actions crossbow submit java

github-actions · 2024-01-10T05:41:17Z

Revision: 85c5f9f

Submitted crossbow builds: ursacomputing/crossbow @ actions-f76ced9dc5

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-10T07:42:35Z

@github-actions crossbow submit java

github-actions · 2024-01-10T07:44:55Z

Revision: 5226173

Submitted crossbow builds: ursacomputing/crossbow @ actions-04546ec6e4

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-11T07:18:03Z

@github-actions crossbow submit java

github-actions · 2024-01-11T07:20:45Z

Revision: c09a3d8

Submitted crossbow builds: ursacomputing/crossbow @ actions-053fa63473

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-11T11:03:39Z

@github-actions crossbow submit java

github-actions · 2024-01-11T11:06:16Z

Revision: 8499caf

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a3a344533

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-11T17:16:09Z

@github-actions crossbow submit java

github-actions · 2024-01-11T17:18:36Z

Revision: 57445c6

Submitted crossbow builds: ursacomputing/crossbow @ actions-bde21cc636

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-12T12:47:05Z

@github-actions crossbow submit java

github-actions · 2024-01-12T12:49:24Z

Revision: 70e9efa

Submitted crossbow builds: ursacomputing/crossbow @ actions-076ac97685

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-17T07:25:29Z

@github-actions crossbow submit java

github-actions · 2024-01-17T07:26:03Z

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7552386532

vibhatha · 2024-01-17T07:34:30Z

Since this PR is already too long, I will be creating a follow up PR to fix the warnings in the following modules

adapter
c
dataset
format
gandiva
maven
memory
performance

Will be addressed here: #39649

lidavidm · 2024-01-17T13:36:47Z

At the end of this we should also be making warnings into errors so that these don't come back up.

vibhatha · 2024-01-17T14:21:07Z

Agreed @lidavidm. Probably need to complete the follow up PR to do that. Also what would be the best way to fail builds with warnings?

jorisvandenbossche · 2024-01-17T15:41:37Z

@github-actions crossbow submit java

github-actions · 2024-01-17T15:44:08Z

Revision: 56a95fd

Submitted crossbow builds: ursacomputing/crossbow @ actions-e636476297

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

lidavidm · 2024-01-17T16:06:29Z

Agreed @lidavidm. Probably need to complete the follow up PR to do that. Also what would be the best way to fail builds with warnings?

Pass -Werror to javac in maven

...ithm/src/test/java/org/apache/arrow/algorithm/dictionary/TestHashTableDictionaryEncoder.java

...gorithm/src/test/java/org/apache/arrow/algorithm/dictionary/TestLinearDictionaryEncoder.java

java/flight/flight-core/pom.xml

java/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java

java/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/GetReadableBuffer.java

java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestCompositeVectorComparator.java

java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java

java/vector/src/test/java/org/apache/arrow/vector/TestLargeListVector.java

java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java

java/vector/src/test/java/org/apache/arrow/vector/TestMapVector.java

vibhatha · 2024-01-22T03:54:25Z

@lidavidm addressed the reviews, but there are some open questions. Appreciate your feedback.

vibhatha · 2024-01-22T03:54:52Z

@github-actions crossbow submit java

github-actions · 2024-01-22T03:57:07Z

Revision: 190e6df

Submitted crossbow builds: ursacomputing/crossbow @ actions-142142f8e6

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

lidavidm · 2024-01-22T16:21:18Z

The only thing I have is to fix the exception message

vibhatha · 2024-01-23T03:33:39Z

@github-actions crossbow submit java

github-actions · 2024-01-23T03:35:54Z

Revision: c1cb671

Submitted crossbow builds: ursacomputing/crossbow @ actions-a48ea38acd

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

conbench-apache-arrow · 2024-01-24T01:54:36Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ae9c0a9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…gs (apache#39529) ### Rationale for this change This PR fixes the warnings generated by the errorprone library. ### What changes are included in this PR? Updating the code to remove warnings. Covered modules - [x] algorithm - [x] compression - [x] flight - [x] tools - [x] vector ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? No * Closes: apache#39330 Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

### What changes are included in this PR? Removing static imports of UTF_8. This has been identified as a minor enhancement as documented here: #39752 and discussed in a review [here](#39529 (comment)). ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? No * GitHub Issue: #39752 Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actions bot added Component: Java awaiting review Awaiting review labels Jan 9, 2024

vibhatha force-pushed the gh-39330 branch from 33fa135 to 736f484 Compare January 11, 2024 05:24

vibhatha force-pushed the gh-39330 branch from 57445c6 to 389237e Compare January 12, 2024 01:39

vibhatha marked this pull request as ready for review January 17, 2024 07:56

vibhatha requested a review from lidavidm as a code owner January 17, 2024 07:56

lidavidm requested changes Jan 17, 2024

View reviewed changes

github-actions bot removed the awaiting review Awaiting review label Jan 17, 2024

vibhatha added 3 commits January 22, 2024 09:15

fix: address reviews v2

220c6d4

fix: address reviews v3

ee8c003

fix: addressing reviews v3

14b23ff

vibhatha force-pushed the gh-39330 branch from 6b73afa to 14b23ff Compare January 22, 2024 03:46

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 22, 2024

fix: addressing reviews v4

190e6df

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 22, 2024

vibhatha mentioned this pull request Jan 23, 2024

[Java] Remove Static imports for Utf8 Usage #39752

Closed

fix: addressing reviews v5

c1cb671

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 23, 2024

lidavidm approved these changes Jan 23, 2024

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jan 23, 2024

lidavidm merged commit ae9c0a9 into apache:main Jan 23, 2024
15 checks passed

lidavidm removed the awaiting merge Awaiting merge label Jan 23, 2024

vibhatha mentioned this pull request Mar 20, 2024

GH-39752: [Java] Remove Static imports for Utf8 Usage #40683

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-39330: [Java][CI] Fix or suppress spurious errorprone warnings #39529

GH-39330: [Java][CI] Fix or suppress spurious errorprone warnings #39529

vibhatha commented Jan 9, 2024 •

edited

Loading

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

vibhatha commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

vibhatha commented Jan 17, 2024

lidavidm commented Jan 17, 2024

vibhatha commented Jan 17, 2024

jorisvandenbossche commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

lidavidm commented Jan 17, 2024

vibhatha commented Jan 22, 2024

vibhatha commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

lidavidm commented Jan 22, 2024

vibhatha commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

conbench-apache-arrow bot commented Jan 24, 2024

GH-39330: [Java][CI] Fix or suppress spurious errorprone warnings #39529

GH-39330: [Java][CI] Fix or suppress spurious errorprone warnings #39529

Conversation

vibhatha commented Jan 9, 2024 • edited Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

vibhatha commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

vibhatha commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

vibhatha commented Jan 17, 2024

lidavidm commented Jan 17, 2024

vibhatha commented Jan 17, 2024

jorisvandenbossche commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

lidavidm commented Jan 17, 2024

vibhatha commented Jan 22, 2024

vibhatha commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

lidavidm commented Jan 22, 2024

vibhatha commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

conbench-apache-arrow bot commented Jan 24, 2024

vibhatha commented Jan 9, 2024 •

edited

Loading